find_package(MPI): cleanup no-op code #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itself even back to CMake 3.9, the code removed duplicates or possibly conflicts with what factory find_package(MPI) is doing, and is at best a NO-OP in contemporary CMake vs. what may have been intended 11 years ago.
scivision
changed the title
Contributor
|
@langou This PR is still very much relevant, if you can merge this one? Might require a rebase |
Contributor
|
I think this would be great to have in before next release. |
langou
approved these changes
Oct 23, 2025
Contributor
|
Thanks to @scivision for the PR. Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even back to CMake 3.9, the code removed duplicates or possibly conflicts with what factory
find_package(MPI)is doing, and is at best a NO-OP in contemporary CMake vs. what may have been intended 11 years ago.